Conversation
ZogStriP
marked this pull request as ready for review
September 11, 2026 09:13
pmusaraj
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, LDAP login ignored its enable toggle and missing connection settings.
This change honors the toggle and requires a hostname plus a UID attribute or custom filter. Anonymous binds and an empty root search base remain supported. Pins older Discourse versions to the previous revision. Depends on discourse/discourse#42484 (merged). Verified: 21 backend/integrity tests, test lint, and Ruby syntax.