Skip to content

ENH: align Wald pre-test, confidence bands, and bootstrap quantiles#241

Merged
jordandeklerk merged 4 commits into
mainfrom
attgt
Mar 13, 2026
Merged

ENH: align Wald pre-test, confidence bands, and bootstrap quantiles#241
jordandeklerk merged 4 commits into
mainfrom
attgt

Conversation

@jordandeklerk
Copy link
Copy Markdown
Owner

@jordandeklerk jordandeklerk commented Mar 13, 2026

See the changes in bcallaway11/did#253 and bcallaway11/did#251

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 91.80328% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
moderndid/did/compute_att_gt.py 80.00% 4 Missing ⚠️
moderndid/did/att_gt.py 96.77% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (eb09b06) and HEAD (251e399). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (eb09b06) HEAD (251e399)
13 12
Files with missing lines Coverage Δ
moderndid/did/compute_aggte.py 92.64% <100.00%> (+0.10%) ⬆️
moderndid/did/mboot.py 93.87% <100.00%> (-2.05%) ⬇️
moderndid/did/att_gt.py 85.18% <96.77%> (+4.69%) ⬆️
moderndid/did/compute_att_gt.py 84.01% <80.00%> (+1.27%) ⬆️

... and 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jordandeklerk jordandeklerk changed the title ENH: align Wald pre-test, confidence bands, and bootstrap quantiles with R did package ENH: align Wald pre-test, confidence bands, and bootstrap quantiles Mar 13, 2026
@jordandeklerk jordandeklerk marked this pull request as ready for review March 13, 2026 15:18
@jordandeklerk jordandeklerk merged commit 76e04a1 into main Mar 13, 2026
17 checks passed
@jordandeklerk jordandeklerk deleted the attgt branch March 13, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants