Fix XVFB issue#6
Open
jamesopti wants to merge 63 commits into
Open
Conversation
Updated Router Functionality
Let dispatch id comparison decide when to run route handlers or not rather than route path check
Add break statement to matchRoutes if match is found
Use path instead of canonicalPath in state object
Fix onRouteComplete to always be called
Fix test running + tests
Fix build script
Add onRouteStart option
feat (Route Metadata): Pass route metadata to the onRouteComplete handler
…uldHandle property (#12) Summary Enable multiple routes to match via the match regex property. Use shouldHandle to break the tie. shouldHandle is an optional property of a route which expects a function which returns a Promise If that Promise resolves without explicitly passing false, the route will be considered a match. The PromiseOrderedFirst utility is written to ensure deterministic behavior for a given set of matched routes regardless of how long any given match's shouldHandle promise takes to resolve.
…pause-method add(method)[FE-896]: Add method for executing code without listening for popstate
…-blocker-async [FE-896] Make executeWithoutPopstateListener asynchronous
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.