Repository navigation
Include target chemical names and formulas in exported recipe filenames - #31
Merged
Merged
Conversation
jordanlegare
marked this pull request as ready for review
September 8, 2026 02:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash-only bulk export names made the recipe folders hard to browse. Generated filenames now include ordered target formulas and chemical names, followed by the existing unique ID.
Example:
Al2O3-ZnO--aluminum-oxide-zinc-oxide--7404270d635e39c5accb82f7.json.Names are sanitized and bounded to 240 ASCII bytes. The ID preserves uniqueness for different precursor routes and component orders. On rerun, unchanged legacy hash-only exports are renamed automatically; edited legacy files are preserved. User-specified single-export paths remain unchanged.
Validation: 21 combination/catalog tests passed, including filename content, ordering, uniqueness, portability, length, bulk resume and legacy migration. A real oxide-pair export produced the expected descriptive filename. Independent review found no blocking issues. Published tree matches tested local tree.