This repository was archived by the owner on Apr 6, 2025. It is now read-only.
Proper typing for LinkProps.#106
Open
slacktracer wants to merge 1 commit intojorgebucaran:masterfrom
slacktracer:master
Open
Proper typing for LinkProps.#106slacktracer wants to merge 1 commit intojorgebucaran:masterfrom slacktracer:master
slacktracer wants to merge 1 commit intojorgebucaran:masterfrom
slacktracer:master
Conversation
Contributor
|
maybe something like this is better? |
Contributor
|
This is the same as #93 |
Contributor
Author
|
@frenzzy Yeah, noticed it a few minutes ago... |
Contributor
Author
|
@frenzzy Actually it's even better as it accounts for all props. Just found out looking the code that all props are passed down... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TS compiler complains without it... So I wasn't being able to add a class to my links as I learned in https://github.com/jorgebucaran/hyperapp-router/issues/86.