Conversation
Implements #226.
|
The colors do look like expected 👍 |
joshdick
left a comment
joshdick
left a comment
There was a problem hiding this comment.
@akin909 @l0nax After correlating with https://github.com/dart-lang/dart-vim-plugin/blob/master/syntax/dart.vim, onedark.vim actually has default highlighting for basically all groups in this PR, so I think the PR is almost entirely redundant.
All highlight links also appear to be redundant, since they're already all defined in https://github.com/dart-lang/dart-vim-plugin/blob/master/syntax/dart.vim.
| call s:h("cssTagName", { "fg": s:red }) | ||
|
|
||
| " Dart | ||
| call s:h("dartTypeDef", { "fg": s:red }) |
There was a problem hiding this comment.
dartTypeDef points to Typedef which already has highlighting in onedark.vim
|
|
||
| " Dart | ||
| call s:h("dartTypeDef", { "fg": s:red }) | ||
| call s:h("dartClassDecl", { "fg": s:red }) |
There was a problem hiding this comment.
dartClassDecl points to dartStorageClass which points to StorageClass, which already has highlighting in onedark.vim, so the first two are redundant
| call s:h("dartInterpolation", { "fg": s:blue }) | ||
| highlight link dartLibrary Include | ||
| call s:h("dartSdkClass", { "fg": s:cyan }) | ||
| call s:h("dartStorageClass", { "fg": s:dark_red }) |
| " Dart | ||
| call s:h("dartTypeDef", { "fg": s:red }) | ||
| call s:h("dartClassDecl", { "fg": s:red }) | ||
| call s:h("dartInterpolation", { "fg": s:blue }) |
There was a problem hiding this comment.
dartInterpolation points to PreProc, which already has highlighting in onedark.vim
| call s:h("dartClassDecl", { "fg": s:red }) | ||
| call s:h("dartInterpolation", { "fg": s:blue }) | ||
| highlight link dartLibrary Include | ||
| call s:h("dartSdkClass", { "fg": s:cyan }) |
There was a problem hiding this comment.
dartSdkClass points to dartType which points to Type, which already has highlighting in onedark.vim
| call s:h("dartStorageClass", { "fg": s:dark_red }) | ||
| highlight link dartExceptions Exception | ||
| highlight link dartStatement Statement | ||
| call s:h("dartConstant", { "fg": s:dark_yellow }) |
There was a problem hiding this comment.
dartConstant points to Constant, which already has highlighting in onedark.vim
|
Then why does the default syntax highlighting not work for dart files? (Everything is yellow) |
2 participants
Implements #226.