Fix shot chart all-time data accuracy and add impact tracking#40
Open
joshmerritt wants to merge 1 commit into
Open
Fix shot chart all-time data accuracy and add impact tracking#40joshmerritt wants to merge 1 commit into
joshmerritt wants to merge 1 commit into
Conversation
- Fix ball_impact event to send project_name (was ball_name), matching all other GA4 events so the worker can correlate impact data - Add validation guards to prevent "(not set)" entries from undefined names - Add fetchImpactDistribution() to worker: queries ball_impact events with real impact_x/impact_y coordinates as custom dimensions from GA4 - Add "All" time range option (days=0 → startDate 2020-01-01) across worker and dashboard for true all-time data - Update ShotChart with 3-path dot generation: session localStorage (real coords) → GA4 impact distribution (real coords from dimensions) → seeded random scatter (fallback) - Pass impactDistribution through data.js → dashboard → ShotChart Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ball_impactparameter naming: was sendingball_nameinstead ofproject_name, preventing the worker from correlating impact data with other eventsfetchImpactDistribution()to the Cloudflare Worker: queriesball_impactevents with realimpact_x/impact_ycoordinates as custom dimensions from GA4days=0→startDate: '2020-01-01') across worker and dashboard for true all-time dataTest plan
impact_xandimpact_yas custom dimensions (not metrics) in GA4 adminball_impactevents sendproject_namein browser consolewrangler deploy— verify?days=0returnsimpactDistributionarray🤖 Generated with Claude Code