Skip to content

Tinyplot#52

Open
grantmcdermott wants to merge 22 commits intojoshuaulrich:masterfrom
grantmcdermott:tinyplot
Open

Tinyplot#52
grantmcdermott wants to merge 22 commits intojoshuaulrich:masterfrom
grantmcdermott:tinyplot

Conversation

@grantmcdermott
Copy link
Copy Markdown

@grantmcdermott grantmcdermott commented Sep 16, 2025

Closes #50.

Placing in draft mode because I want to release tinyplot 0.5.0 first to ensure we don't run into some edge cases. I'll ping when that's done and ready.

That aside, using the current dev version of tinyplot and this fork, we get the following (taken straight from the ?tinyplot.microbenchmark Examples):

library(microbenchmark)
library(tinyplot)

tm <- microbenchmark(rchisq(100, 0),
                     rchisq(100, 1),
                     rchisq(100, 2),
                     rchisq(100, 3),
                     times=100L)
#> Warning in microbenchmark(rchisq(100, 0), rchisq(100, 1), rchisq(100, 2), :
#> less accurate nanosecond times to avoid potential integer overflows

# default plot
tinyplot(tm)

# same, but with aesthetic tweaks
tinyplot(tm,
         main = "Impressive benchmarks",
         sub = "Brought to you by tinyplot",
         fill = "transparent",
         theme = "classic")

# we can use the tinyplot scaffolding to add layer to our plot
 tinyplot_add(type = "jitter", cex = 0.5, alpha = 0.3)

P.S. I got this boilerplate message upon opening this PR. But, unless my eyes deceive me, there's no CONTRIBUTING.md...?

Please review the contributing guide before submitting your pull request. Please pay special attention to the pull request and commit message sections. Thanks for your contribution and interest in the project!

@grantmcdermott grantmcdermott marked this pull request as ready for review September 22, 2025 13:58
@grantmcdermott
Copy link
Copy Markdown
Author

Hi @joshuaulrich, tinyplot 0.5.0 is on CRAN so this PR should now be ready for review.

Minor notes: I bumped the microbenchmark version number in the DESCRIPTION file to a dev version. Not sure of the official policy here. Similarly, I didn't see a NEWS file; not sure if you want me to record a changelog entry anywhere.

@joshuaulrich
Copy link
Copy Markdown
Owner

Thanks! I'm not sure when I'll have time to take a look though. I've been swamped with kids' school, kids' hockey, work, and moving. But I'll get this merged once I'm able to come up for air... haha.

@grantmcdermott
Copy link
Copy Markdown
Author

No rush on my side. Good luck with everything, esp. the move!

@grantmcdermott
Copy link
Copy Markdown
Author

Just ran into a regression for this PR (and thus outside of our normal test suite), following the release of tinyplot 0.6.0.

I'll try to fix in the coming days. Will ping when ready again.

@grantmcdermott
Copy link
Copy Markdown
Author

Hi @joshuaulrich. The minor regression above has been fixed with tinyplot v0.6.1, which is now available on CRAN, so this should be ready to review.

Just a gentle push to take a look when you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tinyplot.microbenchmark method

2 participants