Remove -ci from version string for Home Assistant to comply with semver#121
Open
sepahewe wants to merge 1 commit into
Open
Remove -ci from version string for Home Assistant to comply with semver#121sepahewe wants to merge 1 commit into
sepahewe wants to merge 1 commit into
Conversation
SFPLiberateProject ID: Tip Appwrite has crossed the 50K GitHub stars milestone with hundreds of active contributors |
Author
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
When publishing a new version of the Home Assistant image, a semver was calculated, but "-ci" was appended. This caused a mismatch with the version in config.yaml causing Home Assisstant not being able to find the right image.
Based on config.yaml Home Assistant tried to download hcr.io/josiah-nelson/sfpliberate-addon-aarch64:0.2.0, but the version published is called hcr.io/josiah-nelson/sfpliberate-addon-aarch64:0.2.0-ci
This PR changes the build to a clean semver "0.2.0"
Motivation
Home Assistant can't install without this fix. Fixes #118
Changes
Testing
It's a proposed change to the github workflow, so I can't test it fully.
Screenshots / Logs
Checklist
docker-compose up --build