Remove troubleshooting - #4
Merged
Merged
Conversation
Remove SSH connection and troubleshooting runbook features from the TUI. When connecting via Panorama, API calls route through Panorama to managed firewalls, but SSH requires direct connections to each firewall's management IP. This architectural mismatch makes the current SSH implementation unreliable in Panorama environments. Changes: - Remove ViewTroubleshoot and related handlers - Remove SSH connection functions (connectSSH, updateTroubleshootSSH) - Remove troubleshoot command from navigation and command palette - Keep internal/ssh and internal/troubleshoot packages for future use
The gosec v2.22.11 GitHub Action has a bug where action.yml still references the v2.22.10 Docker image, which bundles Go 1.25.3. This is incompatible with our go.mod requiring Go 1.25.5. Switch to manual installation using gosec's official install script, which uses the Go version from setup-go instead of a bundled version.
golangci-lint v2 requires max-issues-per-linter and max-same-issues to be in a top-level "issues" section, not under "linters.exclusions".
- Fix errcheck issues with proper error handling and nolint comments - Fix gosec issues (TLS InsecureSkipVerify, file permissions) - Fix govet shadows by renaming inner err variables - Fix govet unused writes by adding test assertions - Fix staticcheck nil checks, embedded field selectors, De Morgan's law - Fix prealloc by pre-allocating slices with known capacity - Add nolint:misspell for "environmentals" (PAN-OS API naming) - Delete unused functions: renderInterfaces, formatRow, truncateDash - Convert if-else chains to switch statements - Fix import groupings for goimports compliance
- Fix prealloc by pre-allocating slices with known capacity
The existing //nolint:gosec comments work with golangci-lint but are not recognized when gosec runs directly. Add #nosec directives to suppress intentional security exceptions in both tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Type of Change
Checklist
go test ./...)go vet ./...passesgolangci-lint runpassesTesting
Screenshots (if applicable)
Note: This project uses Conventional Commits. Please ensure your PR title follows the format:
type: description(e.g.,feat: add session filtering,fix: correct API timeout).