Open
Conversation
The default idea doesn't really work as it pick the first assed matching, not the best one. ppc64 and ppc32 would break the heuristic based on ordering.
jpillora
reviewed
Feb 9, 2023
| ) | ||
|
|
||
| var ( | ||
| archRe = regexp.MustCompile(`(arm64|arm|386|amd64|x86_64|aarch64|32|64)`) |
Owner
There was a problem hiding this comment.
Delete 32 and 64? Maybe you need to rebase?
Contributor
Author
There was a problem hiding this comment.
No no.. this is the proposed change. As it is today, this case for example picks ppc64le for amd64. I imagine it just boils down to order. "32" and "64" are not discriminant enough given the current approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default idea doesn't really work as it pick the first assed matching, not the best one. ppc64 and ppc32 would break the heuristic based on ordering.
There may be a better way. Also, not tested..