Image Loaded async from URL + Various fixes#28
Closed
ogonzalezadell wants to merge 12 commits intojpsim:masterfrom
Closed
Image Loaded async from URL + Various fixes#28ogonzalezadell wants to merge 12 commits intojpsim:masterfrom
ogonzalezadell wants to merge 12 commits intojpsim:masterfrom
Conversation
Fix JPSThumbnailAnnotationView frame not beeing placed properly. (view.frame does not update position, bound should be used instead) To see the issue set the background color from the view to black (and set clip to bounds yes) and you will see the view misplaced
Changed file name JPSThumnail to JPSThumbnail
WIP Added sdwebimage (minimal logic) to project,
Added SDWebImage and Indicator for URLImages, updated project and pod dependencies
Updated PodSpec to version 1.1.0 and deployment Target 8.0
Updated Read to include new features
Xcode project fix to be able to compile
…tyIndicator Feature webImagesWithActivityIndicator
ogonzalezadell
changed the title
All Thumbnail works as a button avoiding selecting other thumbnails on the back, also more UX/UI Friendly for users
Button Now is as big as the Thumbnail
Added for each thumbnail the option to choose content mode, by default is aspect fill (even if not defined), but it can be set to aspect fit or others.
Owner
|
Thanks for your hard work on this @ogonzalezadell. Could you please break up this PR into smaller PRs that each just do one thing? That'll greatly simplify reviewing everything, merge the obviously correct stuff and help me focus on the things that actually need attention and discussion. |
Contributor
Author
|
Hi @jpsim, thanks for your response, I'm a bit new to this but will try to separate everything in different PR this week if I find some time. |
Contributor
Author
|
The last pull request is #33, once accepted I will remove this one Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request adds de following changes: