Skip to content

Add arm64 Windows to _jvmfinder.#1372

Merged
marscher merged 1 commit into
jpype-project:masterfrom
tdunkleArm:win-arm64-native-wheels
May 26, 2026
Merged

Add arm64 Windows to _jvmfinder.#1372
marscher merged 1 commit into
jpype-project:masterfrom
tdunkleArm:win-arm64-native-wheels

Conversation

@tdunkleArm

Copy link
Copy Markdown
Contributor

On an arm64 Windows laptop, I'm able to build a native wheel for jpype without any code changes. However, the built wheel can only start the JVM if explicitly passed the arm64 jvm.dll path. This change solves that, so that the JVM can start on an arm64 Windows machine without the DLL path being passed explicitly. I've also added a unit test that confirms that _checkJVMArch() passes in the case of 0xAA64 (43620).

This change would hopefully enable native support for the arm64 Windows ecosystem for jpype, and CI/CD should be manageable with minimal overhead via the GitHub-hosted windows-11-arm runners.

@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.17%. Comparing base (8744832) to head (eafa609).
⚠️ Report is 54 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
+ Coverage   86.12%   86.17%   +0.04%     
==========================================
  Files         112      112              
  Lines       10273    10277       +4     
  Branches     4044     4046       +2     
==========================================
+ Hits         8848     8856       +8     
+ Misses        821      814       -7     
- Partials      604      607       +3     
Files with missing lines Coverage Δ
jpype/_jvmfinder.py 72.61% <100.00%> (+11.07%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Thrameos

Thrameos commented May 20, 2026 via email

Copy link
Copy Markdown
Contributor

@Thrameos Thrameos requested a review from marscher May 24, 2026 04:50
@Thrameos

Copy link
Copy Markdown
Contributor

@marscher I think you would better assess the runners as you have been working on them. Is 1.71 pulled back into the main line?

@marscher

Copy link
Copy Markdown
Member

Thank you for this useful extension. I think we currently have no proper way of testing this, because our current CI pipeline runs on Azure and they do not offer a free ARM64 (despite OSX) runner for Windows.
I'm at doubt to add (and maintain) a duplicate of the testing pipeline for Github Actions just for this case and gonna trust it because of the implementation test you've thankfully provided.

@marscher marscher merged commit 0c8a133 into jpype-project:master May 26, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants