Quality, config containment, and readability coverage pass#64
Merged
Conversation
526cd73 to
6efc857
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
security.allow_external_paths: trueis explicitly enabled.docs/docs-project.yamlfor projects rooted under./docs.list.pop(0)loops withdeque.popleft()in CLI and validator paths.<br>swallowing the next paragraph.Measurements
Measured locally with synthetic before/after equivalents after the optimization pass.
Subproject traversal,
list.pop(0)baseline vsdeque.popleft()current:Readability extraction refactor, same-behavior benchmark without standalone HTML behavior differences:
Interpretation: the
dequetraversal change is a measurable optimization for larger subproject graphs. The readability refactor is primarily a correctness and maintainability change, not a runtime optimization; it intentionally fixes dropped paragraphs after standalone HTML tags.Validation
uv run pytest(677 passed)uv run ruff check docuchango testsuv run mypy docuchango/cli.py docuchango/validator.py docuchango/readability.py docuchango/fixes/bulk_update.pyuv run pytest --cov=docuchango --cov-report=term-missing(677 passed, total coverage72.68%)Notes
Historical multi-project layouts should use
subprojectsfrom a parent config.security.allow_external_paths: trueremains available as an explicit escape hatch for trusted legacy layouts.