Add DrawTarget::{measure_text/measure_glyphs}#171
Open
l4l wants to merge 1 commit intojrmuizel:masterfrom
Open
Add DrawTarget::{measure_text/measure_glyphs}#171l4l wants to merge 1 commit intojrmuizel:masterfrom
l4l wants to merge 1 commit intojrmuizel:masterfrom
Conversation
Contributor
Author
|
Any comment on this, @jrmuizel? Would really like to merge this, so I can switch out to upstream from my fork. |
Owner
|
I'm not in a rush to expand the text handling stuff much. Is it possible for you to measure/layout your text using a proper shaping library? Like skribo, rustybuzz, or allsorts? |
Contributor
Author
|
Sure, that make sense, thanks for a handy create list, I'll try them out. Do you generally opposed to any new text rendering features in raqote? Imo current And also, what's the status of #169 then? Should it be closed with "wont fix" status? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure about API though, it looks quite clumsy now. Besides, do you mind if I run rustfmt at separate PR and add it to CI? It's quite clumsy to turn it off only for that project :\
Besides, I may extend examples/capabilities.rs with this:
(and with removing "photo.png" reading) the result image will be the following:
Details
Closes #169