Refactor dates.ts to use native Intl APIs - #238
Merged
Conversation
Replace hand-rolled English relative-time phrases and duration label tables with Intl.RelativeTimeFormat and Intl.NumberFormat unit style, and unify calendar day/month extraction via DateTimeFormat formatToParts. Co-authored-by: Jeremy Butler <jrmybtlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/dates.tswas carrying a lot of hand-rolled English relative-time and duration label logic. This PR leans on native Intl instead and drops ~130 lines while keeping the public API stable.Changes
timeFrom: always formats withIntl.RelativeTimeFormat. Englishshortmaps to RTFnarrowso documented compact outputs (3d ago,1h ago) stay the same.timeDifference: removesDURATION_LABELS_*tables; segments useIntl.NumberFormat{ style: 'unit', unitDisplay }. Short auto labels now follow ICU (e.g.5 hrinstead of5 hrs).combineDates/ day-month helpers: share oneIntl.DateTimeFormat#formatToPartscalendar path.Verification
pnpm exec vitest run src/*— 339 tests passeddates.test.tsexpectations unchanged