feat/close menu by reverse gesture#297
Open
wassupluke wants to merge 10 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To close #174
I've stayed up way too long looking at this problem. Too tired to pretty this up with markdown at the moment. Here's my work in action: https://youtube.com/shorts/ExDc7Z_frJo?feature=share
Closes the app menu by swipe_dn from 1) the menu, 2) the All Apps title, or 3) the "x". I left the settings icon alone so swiping down on it should not close the app list, as I figured that could be a frustration point for users trying to open settings but accidentally put a little swipe_dn motion on their tap.
Doesn't close the list if scrolling a bit and then back to/past the start in the same gesture. Doesn't close the list if you scroll with great momentum (fling). I swear there was one other edge case I caught and handled but I didn't write it down.