Fixed CI failure caused by dependabot#47
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #47 +/- ##
========================================
Coverage 87.92% 87.92%
========================================
Files 13 13
Lines 414 414
========================================
Hits 364 364
Misses 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the CI workflow to avoid failures when Dependabot opens pull requests, and aligns the repository checkout action with the newer major version used elsewhere in the repo.
Changes:
- Bump
actions/checkoutfromv5tov6in the test workflow. - Skip the Codecov upload step when the workflow is triggered by
dependabot[bot].
Comments suppressed due to low confidence (1)
.github/workflows/test.yml:46
- The Codecov step is only skipped for Dependabot, but it can still fail for other PR contexts where
secrets.CODECOV_TOKENisn’t available (e.g., PRs from forks), sincefail_ci_if_error: truewill make the job fail whentokenis empty/invalid. Consider guarding the upload step on the presence of the secret (or ongithub.event.pull_request.head.repo.fork == false) instead of (or in addition to) checkinggithub.actor.
- name: Upload coverage to Codecov
if: ${{ github.actor != 'dependabot[bot]' }}
uses: codecov/codecov-action@v6
with:
files: ${{ env.CODECOV_PATH }}
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: true
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
df8fb4a to
be83f75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issues
Maintenance
actions/checkoutto v6 (skipped by build(deps): bump actions/checkout from 4 to 6 #44)