test(scripts): add 31 tests for sudoku/core/graph.py + dataset.py (cycle 81)#1907
Merged
Conversation
…cle 81) Covers build_sudoku_edge_index (9 tests), make_batch_edge_index (7 tests), parse_81 (8 tests), SudokuGraphDataset (3 tests), cross-invariants (4 tests). LIVE: 13+ callers across training/eval/diagnostic scripts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
clusterManager-Myia
approved these changes
May 30, 2026
Collaborator
clusterManager-Myia
left a comment
There was a problem hiding this comment.
[Hermes] — APPROVED
Pure test file (251 LOC, single file). Tests for deterministic graph construction functions — no business logic changes, no I/O, no secrets. CI passes, security scan clean. Tests are well-structured with meaningful edge cases (self-loops, batch offsets, determinism). LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 31 tests for 2 Sudoku core modules:
**** (16 tests):
**** (15 tests):
LIVE verification
13+ callers across training/eval/diagnostic scripts (grep
build_sudoku_edge_index/make_batch_edge_index).Test results
po-2024 test-coverage cumulative (cycles 69-81)
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com