test(GradeBookApp): add 73 xunit tests covering grading logic#1928
Merged
Conversation
73 tests across 4 files covering: - FoldAccents (15): Lucene accent folding behavior (tokenize+lowercase+ASCIIFold) - EvaluationRecord (13): Note computation, evaluator properties - StudentRecord (10): Moyenne, Sujets filtering, compatibility props - ProjectModel (35): GroupEvaluation.Moyenne (weighted teacher/student), GroupSizeBonus (6-tier lookup), StatisticalNormalization (z-score), ProcessEvaluations filtering (auto-eval, double, non-inscrit), accent-insensitive name matching, HasStudent, NormalizationDelta Build: 0 errors. Tests: 73 passed, 0 failed. Python suite: 1584 passed (0 regression). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
clusterManager-Myia
approved these changes
May 31, 2026
Collaborator
clusterManager-Myia
left a comment
clusterManager-Myia
left a comment
There was a problem hiding this comment.
[Hermes] — APPROVED
Security: CLEAN
Risk: Low (pure test code, no production logic changes)
Checklist:
- ✅ 4 new test files covering EvaluationRecord, FoldAccents, ProjectModel, StudentRecord
- ✅ 73 xunit tests with clear boundary testing (zero fields, max scores, edge cases)
- ✅ Tests cover: grading formula, accent folding, normalization z-score, auto-eval rejection, group size bonus clamping
- ✅ Proper test isolation — helper factories, no external dependencies
- ✅ csproj correctly references main project, target net9.0
- ✅ No secrets, no hardcoded values
Minor note: FoldAccentsTests uses reflection to access Program.FoldAccents — fragile if method signature changes, but acceptable for testing internal static methods in C#.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add xunit test project \GradeBookApp.Tests\ (net9.0) covering the pure/testable logic of the GradeBookApp grading console app.
Coverage (73 tests, 4 files)
Test results
Context
Coordinator dispatch (cycle 89): pivot from \scripts/smartcontracts/\ (empty — only LIVE script already tested in cycle 71) to GradeBookApp (.NET) coverage audit. Smartcontracts confirmed as dead-code lane per lesson #1885.