Skip to content

fix(Sudoku): add convention print #1946 to 3 silent C# cells#1960

Closed
jsboige wants to merge 1 commit into
mainfrom
fix/sudoku-convention-print-1946
Closed

fix(Sudoku): add convention print #1946 to 3 silent C# cells#1960
jsboige wants to merge 1 commit into
mainfrom
fix/sudoku-convention-print-1946

Conversation

@jsboige
Copy link
Copy Markdown
Owner

@jsboige jsboige commented May 31, 2026

Summary

Convention print #1946 : ajout de Console.WriteLine() informatif sur 3 cells code C# silencieuses dans Sudoku .NET.

Changes

Notebook Cell Avant Apres
Sudoku-1-Backtracking-Csharp cell[6] class def, 0 output Console.WriteLine("Classe BacktrackingDotNetSolver definie avec succes")
Sudoku-11-Choco-Csharp cell[4] #r DLL loading, 0 output Console.WriteLine("DLLs Choco-solver et runtime IKVM chargees")
Sudoku-14-BDD-Csharp cell[32] exercise stub, 0 output Console.WriteLine("Exercice a completer : solveur BDD avec propagation de contraintes")

Validation

  • Sudoku-14 : Papermill .net-csharp 33/33 cells, 0 errors, outputs verifiés
  • Sudoku-1/11 : Papermill echoue sur #!import (problème structurel .NET Interactive, pas lie au convention print). Code C# correct, outputs populera quand executé dans Jupyter Lab
  • Insertions > deletions (enrichment)

Scope

Partition po-2024 (.NET/C# : Sudoku). Suite de PR #1951 (SymbolicAI Python convention print).

Sudoku-1-Backtracking-Csharp: Console.WriteLine after BacktrackingDotNetSolver def
Sudoku-11-Choco-Csharp: Console.WriteLine after IKVM DLL loading
Sudoku-14-BDD-Csharp: Console.WriteLine in exercise stub + Papermill re-exec (33/33 cells, 0 errors)

Sudoku-1/11: Papermill .net-csharp #!import error (structural, code is correct).
Outputs will populate when executed in Jupyter Lab.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

Notebook PR Validation: PASS

  • Notebooks checked: 3
  • Code cells validated: 25
  • Result: All passed

Checks: H.1 (no errors), H.3 (execution_count), C.1 (no banned patterns)
Non-Python kernels (.NET/Lean): C.1 + errors only (execution_count advisory)
QuantConnect notebooks: C.1 + errors only (require QC Cloud for execution)

Copy link
Copy Markdown
Collaborator

@clusterManager-Myia clusterManager-Myia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hermes] — COMMENT_WITH_CONCERNS

Security scan: CLEAN. Static validation: PASS. Notebook validation: PASS.

Concerns:

  1. CI FAIL — Notebook catalog drift. Le catalog ne passe pas. Vérifier que les compteurs cells_with/without_outputs dans le catalog sont cohérents avec l'état réel des notebooks après l'ajout des convention prints.

  2. Adresses IP locales exposées dans outputs DotNet Interactive (Sudoku-14-BDD-Csharp.ipynb). La cellule BDDNode contient un output JavaScript avec des adresses de probe du kernel : 172.17.208.1, 172.21.192.1, 192.168.0.49, et adresses link-local fe80::. Ces adresses exposent la topologie réseau locale (Docker bridges + LAN). Nettoyer ces outputs ou les scrubber avant merge.

  3. No newline at end of file sur Sudoku-1-Backtracking-Csharp.ipynb. Mineur mais incohérent avec les autres notebooks.

@jsboige
Copy link
Copy Markdown
Owner Author

jsboige commented Jun 1, 2026

Superseded by #2006 (conclusions + catalog fix) and #2018 (outputless fix + re-exec + IP cleanup, merged).

@jsboige jsboige closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants