fix(Sudoku): add missing requirements + fix 29 broken navigation links#1972
fix(Sudoku): add missing requirements + fix 29 broken navigation links#1972jsboige wants to merge 2 commits into
Conversation
…ments.txt Sudoku-17-LLM-Python.ipynb imports dotenv and semantic_kernel but these were absent from requirements.txt. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Series was renumbered (2=Genetic->3, 3=ORTools->10, 4=Z3->12, etc.) but markdown navigation links still pointed to old filenames. String-level replacement preserving original JSON formatting. Links fixed: Sudoku-1(4), Sudoku-4(6), Sudoku-5(2), Sudoku-6(2), Sudoku-7(3), Sudoku-8(2), Sudoku-9(2), Sudoku-13(5), Sudoku-14(3) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Notebook PR Validation: PASS
Checks: H.1 (no errors), H.3 (execution_count), C.1 (no banned patterns) |
clusterManager-Myia
left a comment
There was a problem hiding this comment.
[Hermes] — COMMENT_WITH_CONCERNS
Trois points a verifier avant merge:
-
Nouvelles dependances dans requirements.txt — scikit-image, opencv-python-headless et python-dotenv sont ajoutes. Le commentaire indique python-dotenv pour 'API keys'. Justification: ces deps sont-elles effectivement utilisees dans des notebooks Search existants, ou c'est preparatoire ? Si aucun notebook Search n'importe actuellement opencv/scikit-image, ajouter des deps inutilisees alourdit l'environment.
-
Liens de navigation corriges — 29 liens fixes dans les notebooks Sudoku. Concern: le lien dans Sudoku-1-Backtracking-Csharp.ipynb pointe vers 'Sudoku-3-Genetic-Csharp.ipynb' au lieu de 'Sudoku-2-Genetic-Csharp.ipynb'. Verifier que la numerotation est correcte et que les fichiers cibles existent.
-
CI catalog drift FAIL — le COURSE_CATALOG n'est pas synchronise avec les changements reels dans certains notebooks. Rebase ou regenerer le catalog pour corriger.
Summary
Two fixes for the Sudoku series:
1. Missing dependencies in requirements.txt
Sudoku/requirements.txt: addedsemantic-kernel>=0.9andpython-dotenv>=1.0(used by Sudoku-17-LLM-Python)Search/requirements.txt: addedscikit-image>=0.21,opencv-python-headless>=4.8,pillow>=10.0(PyGad-EdgeDetection),python-dotenv>=1.02. Broken navigation links in 9 C# notebooks (29 fixes)
The Sudoku series was renumbered (2=Genetic->3, 3=ORTools->10, 4=Z3->12, etc.) but markdown navigation links in C# notebooks still pointed to old filenames. String-level replacement preserving original JSON formatting.
Verification
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com