Skip to content

fix(Sudoku): add missing requirements + fix 29 broken navigation links#1972

Closed
jsboige wants to merge 2 commits into
mainfrom
fix/sudoku-requirements-dotenv
Closed

fix(Sudoku): add missing requirements + fix 29 broken navigation links#1972
jsboige wants to merge 2 commits into
mainfrom
fix/sudoku-requirements-dotenv

Conversation

@jsboige
Copy link
Copy Markdown
Owner

@jsboige jsboige commented May 31, 2026

Summary

Two fixes for the Sudoku series:

1. Missing dependencies in requirements.txt

  • Sudoku/requirements.txt: added semantic-kernel>=0.9 and python-dotenv>=1.0 (used by Sudoku-17-LLM-Python)
  • Search/requirements.txt: added scikit-image>=0.21, opencv-python-headless>=4.8, pillow>=10.0 (PyGad-EdgeDetection), python-dotenv>=1.0

2. Broken navigation links in 9 C# notebooks (29 fixes)

The Sudoku series was renumbered (2=Genetic->3, 3=ORTools->10, 4=Z3->12, etc.) but markdown navigation links in C# notebooks still pointed to old filenames. String-level replacement preserving original JSON formatting.

Notebook Links fixed
Sudoku-1-Backtracking 4
Sudoku-4-SimulatedAnnealing 6
Sudoku-5-PSO 2
Sudoku-6-AIMA-CSP 2
Sudoku-7-Norvig 3
Sudoku-8-HumanStrategies 2
Sudoku-9-GraphColoring 2
Sudoku-13-SymbolicAutomata 5
Sudoku-14-BDD 3

Verification

  • Diff is clean: only link target strings changed (41 insertions, 41 deletions)
  • No JSON reformatting (string-level replacement, not json.dump)
  • All 29 fixed links now point to existing .ipynb files

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com

jsboigeEpita and others added 2 commits June 1, 2026 00:27
…ments.txt

Sudoku-17-LLM-Python.ipynb imports dotenv and semantic_kernel
but these were absent from requirements.txt.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Series was renumbered (2=Genetic->3, 3=ORTools->10, 4=Z3->12, etc.)
but markdown navigation links still pointed to old filenames.
String-level replacement preserving original JSON formatting.

Links fixed: Sudoku-1(4), Sudoku-4(6), Sudoku-5(2), Sudoku-6(2),
Sudoku-7(3), Sudoku-8(2), Sudoku-9(2), Sudoku-13(5), Sudoku-14(3)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

Notebook PR Validation: PASS

  • Notebooks checked: 9
  • Code cells validated: 100
  • Result: All passed

Checks: H.1 (no errors), H.3 (execution_count), C.1 (no banned patterns)
Non-Python kernels (.NET/Lean): C.1 + errors only (execution_count advisory)
QuantConnect notebooks: C.1 + errors only (require QC Cloud for execution)

Copy link
Copy Markdown
Collaborator

@clusterManager-Myia clusterManager-Myia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hermes] — COMMENT_WITH_CONCERNS

Trois points a verifier avant merge:

  1. Nouvelles dependances dans requirements.txt — scikit-image, opencv-python-headless et python-dotenv sont ajoutes. Le commentaire indique python-dotenv pour 'API keys'. Justification: ces deps sont-elles effectivement utilisees dans des notebooks Search existants, ou c'est preparatoire ? Si aucun notebook Search n'importe actuellement opencv/scikit-image, ajouter des deps inutilisees alourdit l'environment.

  2. Liens de navigation corriges — 29 liens fixes dans les notebooks Sudoku. Concern: le lien dans Sudoku-1-Backtracking-Csharp.ipynb pointe vers 'Sudoku-3-Genetic-Csharp.ipynb' au lieu de 'Sudoku-2-Genetic-Csharp.ipynb'. Verifier que la numerotation est correcte et que les fichiers cibles existent.

  3. CI catalog drift FAIL — le COURSE_CATALOG n'est pas synchronise avec les changements reels dans certains notebooks. Rebase ou regenerer le catalog pour corriger.

@jsboige
Copy link
Copy Markdown
Owner Author

jsboige commented Jun 1, 2026

Superseded by #2006 (conclusions + catalog fix) and #2018 (outputless fix + re-exec + IP cleanup, merged).

@jsboige jsboige closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants