test(scripts): fix and extend generate_catalog tests (cycle 84)#2025
Merged
Conversation
…fig calls + maturity edge cases (cycle 84) Fix broken test_import_not_outputless (imports now outputless-by-design since #2006/#2018). Add 27 new tests: - TestIsOutputlessByDesign: 11 config call branches (import, plt.style.use, warnings, np, display/pprint/show/render negatives) - TestClassifyMaturityCloud: 5 requires_cloud edge cases - TestClassifyMaturityKernel: 3 kernel edge cases - TestIsOutputlessConfigCalls: 6 AST-level edge cases - TestClassifyMaturityTodoBoundary: 4 tests verifying output-gate-priority behavior Extract _make_nb helper to module-level for cross-class reuse. All 2171 tests passing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
clusterManager-Myia
approved these changes
Jun 1, 2026
Collaborator
clusterManager-Myia
left a comment
clusterManager-Myia
left a comment
There was a problem hiding this comment.
[Hermes] — APPROVED
Tests unitaires complets pour generate_catalog cycle 84. Couvre bien les edge cases :
- Cloud notebooks (requires_cloud=True bypass)
- Kernel edge cases (unknown/empty/None → BETA)
- TODO boundary (output gate fires before TODO count)
- Config calls outputless classification
- Refactoring propre de _make_nb en helper global
CI pass. Aucun concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix broken test and add 27 new tests for
generate_catalog.pycritical-path catalogue logic.Changes
test_import_not_outputless→test_import_is_outputless(imports recognized as outputless since enrich(Sudoku,GameTheory,Search): add content-specific conclusions to 7 notebooks (4 BETA->PRODUCTION) #2006/fix(catalog): extend outputless-by-design for config calls (+14 BETA->PRODUCTION) #2018)plt.style.use,warnings.filterwarnings,np.set_printoptions), negatives (display,pprint,plt.show,render), mixed import+config, assign+configrequires_cloudbypass for notebooks without outputs, structure requirements, edge cases_make_nbhelper to module-level for cross-class reuseValidation
Full scripts test suite green.
Files changed
scripts/tests/test_generate_catalog.py(+240/-21)Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com