feat(infra): extract CI/CD and developer experience improvements from WIP#139
feat(infra): extract CI/CD and developer experience improvements from WIP#139
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
Disabled knowledge base sources:
📝 WalkthroughOutcome
Core changes
Risk and compatibility
Validation evidence
Tracking and references
WalkthroughAdds governance and policy artifacts, CI/security workflows, tooling/version pinning, diagram generation + freshness checks, many repository preflight/hook/verification scripts, Makefile and environment updates, and expands the design-system skill docs, contract and evaluation cases. Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Assumptions: focused review scope is only files changed in this PR; I emphasised behavioural, security and CI/gating risks. 🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 005813f582
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Fix .npmrc auto-install-peers comment to avoid pnpm lockfile mismatch - Fix Makefile hooks target to use pnpm exec simple-git-hooks - Fix greptile-review.yml regex escape for / character - Fix ci-required-checks.json check names to match workflow jobs: - dependency-scan → dependency-review - orb-pinning → actions-pinning Fixes open Codex comments that couldn't be marked as resolved.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 474c7e3c89
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| check: lint typecheck test ## Run all checks (lint, typecheck, test) | ||
| check: ## Run all required quality gates | ||
| pnpm check |
There was a problem hiding this comment.
check target
This change switched make check from lint+typecheck+test to pnpm check, but the root package.json has no check script, so make check/make ci now fail immediately with ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL. That breaks the primary quality gate target introduced in this commit.
Useful? React with 👍 / 👎.
|
|
||
| hooks-pre-commit: ## Run local pre-commit gates before creating a commit | ||
| pnpm lint | ||
| pnpm docs:lint |
There was a problem hiding this comment.
The new pre-commit gate invokes pnpm docs:lint, but the repository defines doc:lint (singular) instead; this causes hooks-pre-commit to stop with ERR_PNPM_NO_SCRIPT before running the rest of the checks. As written, the new hook workflow cannot complete on a clean checkout.
Useful? React with 👍 / 👎.
| $(MAKE) related-tests | ||
|
|
||
| hooks-pre-push: ## Run local pre-push governance gates before pushing | ||
| pnpm exec tsx src/cli.ts docs-gate --mode required --json |
There was a problem hiding this comment.
The new hooks-pre-push target runs pnpm exec tsx src/cli.ts ..., but this repo has no src/cli.ts, so the target fails immediately with ERR_MODULE_NOT_FOUND and none of the intended pre-push checks execute. This makes the added governance gate unusable.
Useful? React with 👍 / 👎.
|
|
||
| echo "[prepare-worktree] syncing git hooks" | ||
| git config --local core.hooksPath "$git_common_dir/hooks" | ||
| node scripts/setup-git-hooks.js |
There was a problem hiding this comment.
Fresh evidence in this commit: scripts/prepare-worktree.sh invokes node scripts/setup-git-hooks.js, but that file is not present, so make worktree-ready fails with MODULE_NOT_FOUND during bootstrap. This blocks the newly introduced worktree preparation flow before hooks can be installed.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Summary
Extracts valuable infrastructure, CI/CD, and developer experience improvements from the
wip/auto-prune-20260403bbranch without reverting the Gold Standard 2026 CLI compliance work that was merged in #138.What's Included
New GitHub Workflows
.github/workflows/greptile-review.yml- AI-powered code review automation.github/workflows/secret-scan.yml- Secret detection in CI pipelineHarness CI Configuration
.harness/ci-required-checks.json- Defines required checks for PR gating.harness/ci-provider-transition-status.json- Tracks CI provider migration statusDeveloper Experience
.mise.toml- Mise version manager configuration.npmrc- npm configuration for consistent package management.diagram/- Architecture diagram context and configurationWORKFLOW.md- Developer workflow documentationNew Scripts
scripts/harness-cli.sh- Harness CLI integrationscripts/refresh-diagram-context.sh- Auto-refresh architecture diagramsscripts/check-diagram-freshness.sh- Validate diagram freshnessscripts/check-doc-style.sh- Documentation style validationscripts/check-related-tests.sh- Find tests related to changesscripts/check-semgrep-changed.sh- Run Semgrep on changed filesscripts/check-staged-secrets.sh- Pre-commit secret scanningscripts/codex-enforced- Codex integration for enforced checksscripts/codex-learn- Codex learning modescripts/prepare-worktree.sh- Worktree preparationscripts/verify-work.sh- Work verificationscripts/semgrep-pre-push.yml- Semgrep pre-push configurationUpdates to Existing Files
Makefile- Enhanced build targets and automationharness.contract.json- Expanded contract definitions (+652 lines).github/workflows/pr-pipeline.yml- Pipeline improvements.agents/skills/design-system/- Agent skill updates.codex/environments/environment.toml- Expanded environment configurationFORJAMIE.md- Personal workflow notesChecklist
Testing
Review artifacts
N/A - Infrastructure changes only, no user-facing features.
Notes
wip/auto-prune-20260403bbranch (deleted)