macOS settings publish only with complete frames - #3390
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
macOS settings now publish only when their complete frame commits. Rejected, abandoned, and resource-limited frames preserve the last committed settings and do not fire cursor-blink callbacks.
Fixes #3305
Context
gui_config_statepreviously bypassedCommandDispatcherframe staging even though the BEAM render path emitted it as frame state. That allowed settings to become visible before the rest of the frame was accepted.Changes
guiConfigStatethrough the existing prepared frame transaction while keepingSettingsStateas the sole settings writer.gui_config_statebetweenbegin_frameandcommit_frame.Verification
xcodebuild test -project macos/Minga.xcodeproj -scheme Minga -configuration Debug -derivedDataPath _build/issue-3305-derived CODE_SIGNING_ALLOWED=NO -only-testing:MingaTests/CommandDispatcherStagingTests -only-testing:MingaTests/SettingsStateTests(71 tests passed)mix test test/minga_editor/frontend/frame_transaction_test.exs test/minga_editor/frontend/emit_test.exs test/minga_editor/handlers/gui_action_handler_test.exs(56 tests passed)mix protocol.gen --checkmake lintAcceptance Criteria Addressed