Centralize macOS protocol connection ownership - #3392
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The macOS frontend now gives each protocol connection one main-actor owner for ordered delivery, replacement, and teardown. Startup and reconnect use the same lifecycle, so retired work cannot affect the active encoder.
Closes #3303
Context
AppDelegatepreviously coordinated the encoder, reader, capacity-one handoff, and consumer through separate fields and duplicated their assembly for startup and reconnect. That split ownership made teardown order and retired callbacks difficult to reason about.Changes
ProtocolConnectionas the single owner of the encoder, reader, capacity-one handoff, and consumer task.FileHandleread; transport closure or read completion releases the retired reader.Verification
mix swift.build -- -project macos/Minga.xcodeproj -scheme Minga -configuration Debug -derivedDataPath macos/DerivedData CODE_SIGNING_ALLOWED=NO -quiet testmix protocol.gen --checkmake lintgit diff --check origin/main...HEADAcceptance Criteria Addressed