Fix native Edit menu ownership - #3393
Merged
Merged
Conversation
breznknecht
force-pushed
the
codex/issue-3301-edit-menu
branch
from
September 16, 2026 16:48
1a476b0 to
df0be23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Minga now owns each standard Edit command at its correct SwiftUI command placement, so Undo, Redo, Cut, Copy, Paste, and Select All appear once and have one active shortcut owner. Native text fields keep AppKit responder behavior, while editor actions use one BEAM fallback.
Closes #3301
Context
The prior
.textEditingreplacement did not replace SwiftUI defaults from.undoRedoand.pasteboard, which left duplicate or inactive standard Edit items. This change fixes menu composition without changing the editor Undo and Redo semantics tracked separately in #3285.Changes
.undoRedo,.pasteboard, and.textEditingindependently, while keeping Find and Find and Replace in a separate group.NSMenu, key equivalents, active shortcut ownership, disconnected state, editor Select All, and native field behavior.Verification
xcodebuild test -quiet -project Minga.xcodeproj -scheme Minga -configuration Debug -derivedDataPath DerivedData CODE_SIGNING_ALLOWED=NO -only-testing:MingaTests/PickerQueryFieldTests -only-testing:MingaTests/MingaMenuTestsmix protocol.genmix swift.buildmake lintAcceptance Criteria Addressed