Skip to content

Conversation

@tbhb
Copy link
Contributor

@tbhb tbhb commented Dec 31, 2025

Summary

  • Cache serialized records in Transaction._buffer_serialized during put() and reuse at commit() time, eliminating redundant serialization
  • Remove unused start_mtime parameter from _commit_transaction_buffer
  • Add key length validation to Transaction.delete() and Table.delete() for consistency with put() methods
  • Extract validate_key_length() helper to _keys.py to reduce code duplication

Test plan

  • All existing tests pass (632 tests)
  • Added tests for key length validation in delete operations
  • Type checking passes (basedpyright)
  • Linting passes (ruff)
  • Pre-commit hooks pass

…tion

- Cache serialized records in Transaction._buffer_serialized during
  put() and reuse at commit() time, eliminating redundant serialization
- Remove unused start_mtime parameter from _commit_transaction_buffer
- Add key length validation to Transaction.delete() and Table.delete()
  for consistency with put() methods

Extract validate_key_length() helper to _keys.py to reduce code duplication.
Add tests for key length validation in delete operations.
@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 31, 2025

CodSpeed Performance Report

Merging #10 will not alter performance

Comparing cache-serialized-records-in-tx (ca60cad) with main (75ed41c)1

Summary

✅ 173 untouched
⏩ 1 skipped2

Footnotes

  1. No successful run was found on main (f9bbece) during the generation of this report, so 75ed41c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@tbhb tbhb merged commit 6ed513b into main Dec 31, 2025
30 checks passed
@tbhb tbhb deleted the cache-serialized-records-in-tx branch December 31, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants