refactor: extract type aliases to _types.py to fix import cycle #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_types.pymodule containing all TypeAlias definitions for JSON and key types# pyright: reportImportCycles=falsepragma from_exceptions.py_json.pyand_keys.pyto import types from_types.pyand re-export for backwards compatibilityProblem
Circular import between:
_exceptions.py→ needsJSONObjectandKeyforConflictErrortype annotations_json.py→ needsParseError,LimitErrorfrom_exceptions.py_keys.py→ needsInvalidKeyError,LimitErrorfrom_exceptions.pySolution
Extract pure type aliases to
_types.pywith no dependencies on other JSONLT modules, breaking the cycle.Test plan
uv run basedpyright src/jsonlt/uv run pytest tests/