-
Notifications
You must be signed in to change notification settings - Fork 0
feat(benchmarks): improve measurement accuracy and add missing benchmarks #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…arks - Restructure compact benchmarks to pre-populate history/tombstones in setup - Fix delete benchmark to use unique keys per iteration (no restore cycle) - Add benchmarks for find_one, items, and reload methods - Add EDGE_PARAMS (scale=0, scale=1) for boundary testing - Add generator helpers: create_extended_test_table, create_table_with_history, create_table_with_tombstones
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #6 will create unknown performance changesComparing Summary
Benchmarks breakdown
Footnotes
|
Split benchmarks into 11 shards (from 4) to ensure each completes within the 6-minute timeout. Max shard size is now 43 tests (find) which should complete in ~5.7 minutes at ~8s per test. Shard distribution: - load-reload: 38 tests - get: 25 tests - all: 25 tests - find: 43 tests - find-one: 18 tests - write-compact: 32 tests - keys-delete: 31 tests - items: 25 tests - count: 25 tests - has: 31 tests - memory: 18 tests
Split benchmarks into 15 shards to ensure each completes within 5 minutes. Separated slow vs non-slow tests for expensive operations (all, items, keys) using the slow marker. Shard distribution (estimated times): - get: 25 tests (~3m) - count: 25 tests (~3m) - has: 31 tests (~3m) - find-one-delete: 24 tests (~2m) - write-compact: 32 tests (~5m) - load: 19 tests (~4m) - reload: 19 tests (~4m) - keys-ci: 12 tests (~2.5m) - keys-slow: 13 tests (~2.5m) - all-ci: 12 tests (~3m) - all-slow: 13 tests (~3.5m) - items-ci: 12 tests (~3m) - items-slow: 13 tests (~3.5m) - find-high: 19 tests (~3m) - find-other: 24 tests (~4m) Memory tests excluded for now due to memray profiling overhead.
Exclude slow tests from PR benchmarks to ensure completion under 5 minutes. Slow tests take ~24s each vs ~7s for CI tests. Shard distribution (7 shards, ~176 tests total): - load-reload: 12 tests (~1.5m) - get: 12 tests (~1.5m) - find: 30 tests (~3.5m) - find-one-delete: 24 tests (~2m) - write-compact: 32 tests (~5m) - all-keys-items: 36 tests (~4m) - count-has: 30 tests (~3.5m)
Summary
compact()performancefind_one,items, andreloadmethodsEDGE_PARAMS(scale=0, scale=1) for boundary testing on appropriate testscreate_extended_test_table,create_table_with_history,create_table_with_tombstones