Keep one lockup, and render it as PNG - #17
Merged
Merged
Conversation
The two baked-background lockups are gone. What they were for — a logo on a surface whose colour you know — the hero pair already does without a plate, and the plate was the thing that showed: the light lockup on a dark extension page is a white slab. jsray-logo-hero-dark.png is the SVG rendered at 1520×480, because a VS Code Marketplace README cannot reference SVG. The brand README no longer describes files that are not here.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
jsray | cc39ad5 | Commit Preview URL Branch Preview URL |
Sep 03 2026, 03:17 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two baked-background lockups are gone. What they were for — a logo
on a surface whose colour you already know — the hero pair does without
a plate, and the plate was the thing that showed: the light lockup on a
dark extension page renders as a white slab, which is how the VS Code
listing was opening.
jsray-logo-hero-dark.pngis that SVG rendered at 1520×480, because aVS Code Marketplace README cannot reference SVG. It is the only file
added.
Checked before removing them: nothing in this repository referenced the
deleted files — the site pages use
jsray-mark-dark.svg, and the onlyreferences anywhere were the two READMEs in
jsray-vscode, which nowpoint at the hero. The brand README no longer describes files that are
not here.
164 tests pass and the site builds with
assets/brandintact.