Skip to content

Require one concern per commit, and a bump of its own - #21

Merged
liuyingjierun merged 3 commits into
mainfrom
docs/commit-granularity
Sep 5, 2026
Merged

liuyingjierun merged 3 commits into
mainfrom
docs/commit-granularity

Conversation

@liuyingjierun

Copy link
Copy Markdown
Contributor

The rule that was missing when 0.0.2-beta.3's subject landed on sixteen paths, plus the check that enforces it in tools/release.sh — verified against that commit, it rejects exactly CODE_OF_CONDUCT.md and .github/workflows/ci.yml.

Also drops the status line from the footer comment; the status is asserted by tests/contract.test.mjs.

The subject is printed beside every file the commit touched, so folding four
unrelated changes into one prints a sentence that is a quarter true of each.
Releasing 0.0.2-beta.3 put the same line on sixteen paths, CODE_OF_CONDUCT.md
and .github/ among them, where it described nothing that had changed.

The rule that was missing is about granularity, not wording — the wording rules
above were followed.
The release commit's subject lands on every file it touched. 0.0.2-beta.3's
also carried a Code of Conduct contact and a CI job, so that sentence became
the description of CODE_OF_CONDUCT.md and .github/ — neither of which had
anything to do with npm or the site.

Checked against that commit, this rejects exactly those two paths.
The comment carried a status line — which integrations were out, which were
not — beside the rule it was explaining. The rule is what a reader needs, and
the status is asserted by tests/contract.test.mjs rather than by a sentence
that goes stale between releases.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
jsray 622f6b1 Commit Preview URL

Branch Preview URL
Sep 05 2026, 05:31 PM

@liuyingjierun
liuyingjierun merged commit 825d9f5 into main Sep 5, 2026
6 checks passed
@liuyingjierun
liuyingjierun deleted the docs/commit-granularity branch September 5, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant