Addition of filtering by spool type#40
Merged
Merged
Conversation
Owner
|
very cool, let me know when you think it's ready to be merged. |
Contributor
Author
|
@jtrmal Thanks, I'd say it's ready now unless you feel there's anything left to refine/add. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #39, this adds the ability to filter by general type of spool material/color:
Each existing spool has been updated with a new
spool_typeparam, which is then used in dynamic filtering using JavaScript on the portfolio page. I've made sure this filtering works with URL/history handling, so users can use back/forward controls to navigate between filter states and, if changed page, will return to the page in the previously filtered state.I also designed some custom icons for the options, which are shown alone when in mobile view to keep things compact.
I've tested this against Firefox and Chromium (Brave).
This also applies a minor design tweak to existing content, by reducing the padding of lists on the home portfolio cards to provide a little more space and closer align them to the titles. I can remove this from the PR if desired though.
Previews
Desktop Preview
Mobile Preview