refactor: headers

[juanbzz]

No description provided.

[github-actions]

🤖 miso Code Review

📝 Review for internal/agents/reviewer.go

I'll review the changes to internal/agents/reviewer.go focusing on the specific additions and their impact.

Change Impact Analysis

🟢 Safe - Changes add new functionality without breaking existing code

Code Quality Issues

🟡 Warning: HTTP Client Configuration

Lines 71-75

client := &http.Client{
    Transport: transport,
}

• The HTTP client lacks timeout configuration
• Could lead to hanging connections in production
• Fix by adding reasonable timeouts:

client := &http.Client{
    Transport: transport,
    Timeout: 30 * time.Second,
}

💡 Suggestion: Constants Organization

Lines 16-19

const (
    website = "https://github.com/j0lvera/miso"
    name    = "miso"
)

• Consider moving these to a dedicated constants package
• These values might be needed elsewhere in the application
• Makes configuration more centralized and maintainable

Consistency & Patterns

✅ Good: Custom Transport Implementation

Lines 21-33

type headerTransport struct {
    base    http.RoundTripper
    headers map[string]string
}

• Clean implementation of http.RoundTripper interface
• Good separation of concerns
• Follows Go interfaces best practices

✅ Good: Error Handling

Lines 57-59

if apiKey == "" {
    return nil, fmt.Errorf("OPENROUTER_API_KEY environment variable is not set")
}

• Clear error message
• Follows project error handling conventions
• Early validation of required configuration

⚠️ Minor Issue: Header Constants

Lines 62-65

headers := map[string]string{
    "HTTP-Referer": website,
    "X-Title":      name,
}

• Consider defining header keys as constants
• Makes maintenance easier and prevents typos
• Example:

const (
    headerReferer = "HTTP-Referer"
    headerTitle   = "X-Title"
)

Additional Recommendations

1. Documentation

   • Add godoc comments for the headerTransport type
   • Document why these specific headers are required

2. Testing

   • Add unit tests for the new headerTransport
   • Include test cases for header injection

3. Error Handling

   • Consider adding validation for the base transport in headerTransport
   • Add error wrapping for transport errors

The changes overall are well-structured and follow Go best practices. The main concerns are around HTTP client configuration and constants organization, but these are relatively minor issues.