feat!: Better api to create archive.#127
Merged
Merged
Conversation
mgautierfr
force-pushed
the
create_api
branch
5 times, most recently
from
4d847a3 to
b82241b
Compare
Member
Author
|
@sergeevabc, As you have commented on #31, if you have time, a feedback on this PR and the introduced API would be appreciated. Thanks ! |
Instead of providing a strip_prefix, now arx trim all parents from given path by default. We add an option `--keep-parents` to use the full path. And `--dir-as-root` to trim the directory itself (and so put files in the directory directly in the root of the archive). In the process, we now accept absolute path.
We don't know in which order we will add the files so we cannot expect file0.bin to fail.
mgautierfr
force-pushed
the
create_api
branch
from
b82241b to
478f080
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of providing a strip_prefix, now arx trim all parents from given
path by default.
We add an option
--keep-parentsto use the full path. And--dir-as-rootto trim the directory itself (and so put files in the directory directly
in the root of the archive).
In the process, we now accept absolute path.
Fix #111