Rework "Fix race condition bugs" to fix pytest failure - #71
Open
uncoldice wants to merge 1 commit into
Open
Conversation
RaulSMS
pushed a commit
to kellergoech/python-can-j1939
that referenced
this pull request
Aug 19, 2026
Addresses review feedback on juergenH87#71 (both Copilot and khauersp) requesting a regression test for the fix. test_add_notifier_after_notifier_stop_still_delivers reproduces the exact sequence: add a notifier, stop it (setting listener.stopped=True via can.Notifier.stop()), remove it, then add a brand new notifier and assert a real frame sent on the bus is actually delivered to a subscriber. Verified this fails without the fix (reverted electronic_control_unit.py locally, confirmed the test catches the regression with "Frame was not delivered...") and passes with it.
RaulSMS
pushed a commit
to kellergoech/python-can-j1939
that referenced
this pull request
Aug 19, 2026
…er-stopped-flag fix: reset MessageListener.stopped when re-adding to a notifier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rework of #42, which brought in some CI failures.