Open
Conversation
mizuirorivi
force-pushed
the
rivi/feature/change_color_on_heatmap
branch
from
99acfdd to
085f404
Compare
Contributor
Author
jumang4423
reviewed
Dec 15, 2024
| "color": "^4.2.3", | ||
| "firebase": "^11.0.2", | ||
| "framer-motion": "^11.14.4", | ||
| "js-cookie": "^3.0.5", |
| /> | ||
| </FormControl> | ||
| <FormControl> | ||
| <FormLabel>color map(heatmap)</FormLabel> |
|
|
||
| const level3Color = darkenHexColor(userColor, 40); | ||
|
|
||
| const getColor = (count: number | undefined): string => { |
Member
There was a problem hiding this comment.
darkenHexColorはコンポーネントの外に定義されるのに getColorはコンポーネント内に定義される
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ユーザーが定義した色でコンポーネントを変えられるようにする基礎を作成した
とりあえず今の所heatmapだけ
この機能がいいかどうか感じたこと教えて
また、コードのレビューお願いしまっす