Delete ES element.#733
Open
fabricematrat wants to merge 3 commits intojuju:v5-unstablefrom
fabricematrat:240-delete-entity-ES
Open
Delete ES element.#733fabricematrat wants to merge 3 commits intojuju:v5-unstablefrom fabricematrat:240-delete-entity-ES
fabricematrat wants to merge 3 commits intojuju:v5-unstablefrom
fabricematrat:240-delete-entity-ES
Conversation
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
mhilton
approved these changes
Mar 3, 2017
internal/charmstore/store.go
Outdated
| } | ||
| } | ||
|
|
||
| if s.ES == nil || s.ES.Database == nil { |
Contributor
There was a problem hiding this comment.
you don't need to do this check in both places, just call s.ES.delete and let it return nil if its not configured.
urosj
suggested changes
Mar 3, 2017
Contributor
urosj
left a comment
urosj
left a comment
There was a problem hiding this comment.
When charm/5 is deleted, charm/4 needs to be reindexed. We have to keep the promise of indexing the last revision/
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.