Add deep analysis of all 21 atom components - #1
Open
OscarGauss wants to merge 2 commits into
Open
Conversation
OscarGauss
force-pushed
the
claude/analyze-test-coverage-hmpyk
branch
from
April 25, 2026 20:05
c1705cc to
f8af273
Compare
Before this change, `import { Button } from '@juki-team/base-ui'`
forced webpack/Next.js to load the entire monolithic main.js including
CodeMirror, Milkdown, Excalidraw, KaTeX, Recharts, Handsontable, etc.
even on pages that don't use them.
Changes:
- Add "sideEffects": ["*.scss", "*.css"] to package.json so webpack
can safely tree-shake unused JS modules
- Enable preserveModules: true in rollup ESM output so each source
module becomes its own file instead of one concatenated main.js
- Remove manualChunks (incompatible with preserveModules)
- Update module field and all exports paths to match new dist/esm
structure (e.g. dist/esm/index.js instead of dist/esm/main.js)
NOTE: Build must be verified in an environment with NPM_GITHUB_TOKEN
configured. The exports paths assume preserveModulesRoot: 'src' maps
src/index.ts -> dist/esm/index.js, src/helpers/index.ts ->
dist/esm/helpers/index.js, etc.
https://claude.ai/code/session_01E4AA7iepiyeX67Li1diwca
Rollup with preserveModules keeps the named entry files (main.js, helpers.js, etc.) from the input config, so the original export paths in package.json are correct as-is. Only sideEffects is the new field. https://claude.ai/code/session_01E4AA7iepiyeX67Li1diwca
OscarGauss
force-pushed
the
claude/analyze-test-coverage-hmpyk
branch
from
April 25, 2026 21:55
f8af273 to
d8c3d20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identifies 4 critical bugs (DateLiteral padStart on numbers,
InputSelect stale state, DetectRequestAnimationFrame memory leak,
Button missing Space key), pervasive accessibility gaps (no focus
trap in Modal, no keyboard nav in Select/MultiSelect/InputToggle),
type safety issues, API inconsistencies, and performance concerns.
https://claude.ai/code/session_01E4AA7iepiyeX67Li1diwca