Restructure if-else statements and TODO for Date formatting#3
Open
jaydenb2008 wants to merge 1 commit intojulianalg:masterfrom
Open
Restructure if-else statements and TODO for Date formatting#3jaydenb2008 wants to merge 1 commit intojulianalg:masterfrom
jaydenb2008 wants to merge 1 commit intojulianalg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall very solid work. While looking at the code, I felt a little overwhelmed because every single method had a Javadoc. For simple getters, setters, and constructors, I think one general javadoc explaining the attribute would be sufficient.