-
Notifications
You must be signed in to change notification settings - Fork 18
Re-organize Jumpstarter packages to allow sparse dependency tree per-package #225
Changes from all commits
3eaebda
af267a8
eabdbb7
4c61580
e72cc41
07bed5a
a05c9f0
10f7de5
ff1504c
03d7932
c4ec102
83a27a2
5087c15
cfb9113
180ed74
a178b63
0d5c6e2
41e837e
b6b933b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,9 +3,9 @@ managed: | |
| enabled: true | ||
| plugins: | ||
| - remote: buf.build/protocolbuffers/python | ||
| out: . | ||
| out: ./packages/jumpstarter_protocol/jumpstarter_protocol | ||
| - remote: buf.build/grpc/python | ||
| out: . | ||
| out: ./packages/jumpstarter_protocol/jumpstarter_protocol | ||
|
Comment on lines
+6
to
+8
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Path mismatch detected in buf.gen.yaml configuration The output path in
🔗 Analysis chainVerify that the new output paths are correct. The updated paths in 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# This script verifies that the directory for generated code is present
fd "jumpstarter_protocol" --hidden --no-ignore
Length of output: 98 |
||
| inputs: | ||
| - git_repo: https://github.com/jumpstarter-dev/jumpstarter-protocol.git | ||
| subdir: proto | ||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
The relative path in
raw-optionsneeds to be../../../to correctly reference the repository rootBased on the file location at
git/__templates__/driver/pyproject.toml.tmpl, two levels of../would only reach thegit/directory. To properly reference the repository root, three levels (../../../) are required.🔗 Analysis chain
Confirm the relative path for version control is still valid.
Previously, the
raw-optionspath was set to../../../, and now it's changed to../../. Ensure this adjustment correctly references the repository root under the new directory structure. Once satisfied, feel free to resolve this comment.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 74