This repository was archived by the owner on Jan 23, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Fix Ruff version mismatch and config issues #234
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4cee098
Fix Ruff version mismatch and config issues
kirkbrauer 9ef8702
Fix import ordering
kirkbrauer 24f07b3
Fix pre-commit hook version
kirkbrauer 58c3375
Upgrade devcontainer with latest uv version
kirkbrauer aa1555e
Merge branch 'main' into fix-ruff
mangelajo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,15 @@ | ||
| FROM debian:bookworm-slim AS builder | ||
|
|
||
| WORKDIR /opt | ||
|
|
||
| # The installer requires curl (and certificates) to download the release archive | ||
| RUN apt-get update && \ | ||
| apt-get install -y --no-install-recommends \ | ||
| ca-certificates \ | ||
| curl | ||
|
|
||
| SHELL [ "/bin/bash", "-o", "pipefail", "-c" ] | ||
|
|
||
| # Download the latest installer | ||
| ADD https://astral.sh/uv/install.sh uv-installer.sh | ||
|
|
||
| # Run the installer then remove it | ||
| RUN sh uv-installer.sh | ||
|
|
||
|
|
||
| FROM mcr.microsoft.com/vscode/devcontainers/base:bookworm | ||
|
|
||
| ENV CARGO_HOME="/opt/.cargo/bin" | ||
| ENV PATH="$CARGO_HOME/:$PATH" | ||
|
|
||
| ENV PYTHONUNBUFFERED=True | ||
| ENV UV_LINK_MODE=copy | ||
|
|
||
| WORKDIR /opt | ||
|
|
||
| COPY --from=builder /root/.cargo/bin/uv $CARGO_HOME/uv | ||
| COPY --from=builder /root/.cargo/bin/uvx $CARGO_HOME/uvx | ||
| COPY --from=ghcr.io/astral-sh/uv:latest /uv /bin/uv | ||
| COPY --from=ghcr.io/astral-sh/uv:latest /uvx /bin/uvx | ||
| COPY ./.python-version ./ | ||
|
|
||
| RUN uv python pin "$(cat .python-version)" | ||
|
|
||
| RUN chown -R vscode $CARGO_HOME | ||
|
|
||
| # Install required tools for development | ||
| RUN apt-get update && apt-get install -y iperf3 libusb-dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| default_stages: [pre-commit] | ||
| repos: | ||
| - repo: https://github.com/astral-sh/ruff-pre-commit | ||
| rev: v0.3.5 | ||
| rev: v0.9.2 | ||
| hooks: | ||
| - id: ruff | ||
| name: Ruff check | ||
| description: "Run 'ruff check' for extremely fast Python linting" | ||
| args: [ --fix ] | ||
| - id: ruff | ||
| name: Ruff Check | ||
| description: "Run 'ruff check' for extremely fast Python linting" | ||
| args: [ --fix ] | ||
|
|
||
| - id: ruff-format | ||
| name: Ruff format | ||
| description: "Run 'ruff format' for extremely fast Python formatting" | ||
| - id: ruff-format | ||
| name: Ruff Format | ||
| description: "Run 'ruff format' for extremely fast Python formatting" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,5 +35,4 @@ build-backend = "hatchling.build" | |
| dev = [ | ||
| "pytest-cov>=6.0.0", | ||
| "pytest>=8.3.3", | ||
| "ruff>=0.7.1", | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update to jmp client lease request
But the important thing is fixing ruff now... merging :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit worried about the non deterministic behavior of ruff. Maybe we need to make sure everyone upgrades their uv and fully syncs the workspace. 🤷♂️