This repository was archived by the owner on Jan 23, 2026. It is now read-only.
preserve history from parent shell in zsh#573
Merged
mangelajo merged 2 commits intojumpstarter-dev:mainfrom Jul 24, 2025
Merged
preserve history from parent shell in zsh#573mangelajo merged 2 commits intojumpstarter-dev:mainfrom
mangelajo merged 2 commits intojumpstarter-dev:mainfrom
Conversation
fixes #560 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
✅ Deploy Preview for jumpstarter-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
WalkthroughThis change updates the shell launching logic in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant launch_shell
participant Shell (bash/zsh)
Note over launch_shell: Determine shell type
alt bash
launch_shell->>Shell (bash/zsh): Start with ["bash", "--norc", "--noprofile"]
else zsh
launch_shell->>Shell (bash/zsh): Start with ["zsh"] (+ "--no-rcs" if needed)
alt HISTFILE not set
launch_shell->>Shell (bash/zsh): Set HISTFILE=~/.zsh_history
end
launch_shell->>Shell (bash/zsh): Add "-o inc_append_history" and "-o share_history"
end
Estimated code review effort2 (~12 minutes) Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
mangelajo
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #560
Summary by CodeRabbit
New Features
Style