This repository was archived by the owner on Jan 23, 2026. It is now read-only.
[Backport release-0.7] unregister from controller only on proper exit#662
Merged
mangelajo merged 1 commit intorelease-0.7from Sep 29, 2025
Merged
[Backport release-0.7] unregister from controller only on proper exit#662mangelajo merged 1 commit intorelease-0.7from
mangelajo merged 1 commit intorelease-0.7from
Conversation
exceptions raised duing serve() and lease changes keep the exporter registered with controller to avoid quick online/offline transitions since the internal logic restarts the jumpstarter child process within few seconds. On termination signal the unregistration still happens as the parent process also terminates. Note it still causes offline/online bounce if it is immediatelly restarted via systemd service for example. (cherry picked from commit 8587858)
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Member
|
Do not merge yet, verifying on community server |
Member
|
it works |
mangelajo
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-0.7, triggered by a label in #659.