Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

unzboot with zstd landed in Fedora 42#666

Merged
mangelajo merged 2 commits intojumpstarter-dev:mainfrom
michalskrivanek:unzboot-wa
Sep 30, 2025
Merged

unzboot with zstd landed in Fedora 42#666
mangelajo merged 2 commits intojumpstarter-dev:mainfrom
michalskrivanek:unzboot-wa

Conversation

@michalskrivanek
Copy link
Copy Markdown
Contributor

@michalskrivanek michalskrivanek commented Sep 29, 2025

dropping the workaround

Summary by CodeRabbit

  • Chores
    • Removed an outdated Fedora-specific dependency installation step, simplifying the setup and reducing special-casing.
    • Eliminated reliance on installing packages from external URLs, improving consistency and reliability across environments.
    • Build flow and outputs remain unchanged for end users; standard dependency installation and subsequent build steps continue as before.

dropping the workaround
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 29, 2025

Walkthrough

Removed a Fedora 43-specific unzboot RPM workaround from the aarch64-itb build script. The rest of the script remains unchanged, continuing dependency installation, Buildroot clone, and initramfs build steps.

Changes

Cohort / File(s) Summary of Changes
Build script cleanup
packages/jumpstarter-driver-flashers/oci_bundles/aarch64-itb/build_fits.sh
Deleted the commented note and rpm -Uvh block that installed unzboot for Fedora 43; no other logic modified; existing dependency install and Buildroot/initramfs flow unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • jumpstarter-dev/jumpstarter#644 — Also touches the same Fedora-43 unzboot/rpm workaround in the same script, making it directly related.

Poem

A nibble of code, a workaround gone,
I thump with joy at a cleaner dawn.
No RPM detours, no tangled thread,
The build hops forward, light as bread.
Ears up, paws down—ship it ahead! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The title “unzboot with zstd landed in Fedora 42” does not reflect the actual change, which is removing a Fedora 43-specific unzboot RPM workaround rather than introducing zstd support or targeting Fedora 42. It is misleading because the pull request deletes a special case rather than adding coverage for new functionality. Please revise the title to accurately summarize the main change, for example “Remove Fedora 43-specific unzboot RPM workaround,” so that it clearly communicates the intent of the pull request.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3aacac5 and 8eb627c.

📒 Files selected for processing (1)
  • packages/jumpstarter-driver-flashers/oci_bundles/aarch64-itb/build_fits.sh (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/jumpstarter-driver-flashers/oci_bundles/aarch64-itb/build_fits.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: build
  • GitHub Check: pytest-matrix (macos-15, 3.13)
  • GitHub Check: pytest-matrix (ubuntu-24.04, 3.13)
  • GitHub Check: pytest-matrix (macos-15, 3.12)
  • GitHub Check: pytest-matrix (macos-15, 3.11)
  • GitHub Check: pytest-matrix (ubuntu-24.04, 3.11)
  • GitHub Check: pytest-matrix (ubuntu-24.04, 3.12)
  • GitHub Check: e2e
  • GitHub Check: Redirect rules - jumpstarter-docs
  • GitHub Check: Header rules - jumpstarter-docs
  • GitHub Check: Pages changed - jumpstarter-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 29, 2025

Deploy Preview for jumpstarter-docs ready!

Name Link
🔨 Latest commit 8eb627c
🔍 Latest deploy log https://app.netlify.com/projects/jumpstarter-docs/deploys/68db9a1acab9910008ae35ed
😎 Deploy Preview https://deploy-preview-666--jumpstarter-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mangelajo mangelajo merged commit 748be71 into jumpstarter-dev:main Sep 30, 2025
18 checks passed
@jumpstarter-backport-bot
Copy link
Copy Markdown

Successfully created backport PR for release-0.7:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants