Change the default keepalive timeout#675
Conversation
The default timeout of 5s is excessively low and causes issues under pressure. See https://github.com/jumpstarter-dev/jumpstarter/issues/674 for more details. Fixes-Issue: #674
✅ Deploy Preview for jumpstarter-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughUpdated the default gRPC keepalive timeout in packages/jumpstarter/jumpstarter/common/grpc.py by changing keepalive_timeout_ms from 5000 to 180000 within _override_default_grpc_options. No other defaults or control flow were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Successfully created backport PR for |
The default timeout of 5s is excessively low and causes issues under pressure.
See https://github.com/jumpstarter-dev/jumpstarter/issues/674 for more details.
Fixes-Issue: jumpstarter-dev/jumpstarter#118
Summary by CodeRabbit