fix: correctly check bounds on read_at#22
Merged
Merged
Conversation
dustinpho
approved these changes
Nov 14, 2025
e24a09e to
8493db4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're incorrectly checking bounds on
read_atcalls. The kernel happens to be calling us correctly through FUSE but nothing was actually stopping us from reading beyond the bounds of a file.The bug is a one-line fix: actually take into account the read offset when calculating read length:
The problem was masked by object store implementations happily returning partial ranges and the kernel doing bookeeping correctly. All of our fuzz tests at the moment are mediated through the kernel's FUSE driver, so they didn't turn this up.
I added a simple test for this that would have caught the original bug with an out-of-bounds. It might be worth adding a direct volume fuzz just for this.