Skip to content

fix(discovery): fall back to directory name for audio model type detection #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryancee wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Open

fix(discovery): fall back to directory name for audio model type detection #849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions omlx/model_discovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,20 @@ def detect_model_type(model_path: Path) -> ModelType:
if normalized_type.startswith("lfm") and normalized_type not in EMBEDDING_MODEL_TYPES:
return "audio_sts"

# Directory-name fallback for audio models whose config.json omits model_type.
# Some model families (e.g. NeMo-format parakeet) do not include a top-level
# model_type field, so the checks above find nothing. As a last resort, match
# the first hyphen-separated segment of the model directory name against the
# same mlx-audio model-type sets used above.
dir_stem = model_path.name.lower().split("-")[0]
if dir_stem and dir_stem not in _LLM_TYPE_COLLISIONS:
if dir_stem in AUDIO_TTS_MODEL_TYPES:
return "audio_tts"
if dir_stem in AUDIO_STT_MODEL_TYPES:
return "audio_stt"
if dir_stem in AUDIO_STS_MODEL_TYPES:
return "audio_sts"

return "llm"


Expand Down