fix(omlx_app): health checks and local URLs honor bind host#878
Open
DKev wants to merge 1 commit intojundot:mainfrom
Open
fix(omlx_app): health checks and local URLs honor bind host#878DKev wants to merge 1 commit intojundot:mainfrom
DKev wants to merge 1 commit intojundot:mainfrom
Conversation
Author
|
Fixes #963 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: With a custom bind address (only listening on a non-loopback IP), the app always hit http://127.0.0.1:{port}, so health never succeeded and startup looked hung; port/TCP checks could also misbehave.
Change: Read server.host from {base_path}/settings.json and use it to build local health/base URLs; treat "" / 0.0.0.0 / :: as loopback for local probes; bracket IPv6 in URLs; align admin dashboard/stats/API key update URLs and TCP probe targets.
Tests: Added coverage for URL resolution and custom-bind health/API URLs in tests/test_omlx_app.py.