Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da601f9ac2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| from dataclasses import dataclass | ||
|
|
||
| from .maps import ( | ||
| from .mappings import ( |
There was a problem hiding this comment.
Restore
utsuho.maps compatibility or update API docs
Switching imports to utsuho.mappings here coincides with removing the utsuho.maps module, but the published API docs still reference utsuho.maps (docs/source/api/utsuho.rst:17, docs/source/api/utsuho.maps.rst:4). In this state, import utsuho.maps raises ModuleNotFoundError, so doc generation for that page and any users following the documented path break; either keep a compatibility shim module or update/remove those API doc entries in the same change.
Useful? React with 👍 / 👎.
Summary
This PR prepares
2.3.2.The main change is an internal refactor that splits the former
utsuho.mapsmodule into a dedicatedutsuho.mappingspackage and reorganizes mapping definitions by responsibility, without changing conversion behavior.Changes
utsuho.mappings.commonfor shared mapping type aliasesutsuho.mappings.widthfor half-width/full-width mapping definitionsutsuho.mappings.kanafor hiragana/katakana mapping definitionsutsuho.mappingsas the import entry point for internal mapping definitionsutsuho.convertersto import fromutsuho.mappingsutsuho.mapsmodule2.3.2Notes
utsuho.mapswas treated as an internal implementation detail and removed accordinglyVerification
0003_2.3.2.json0002_2.2.1.jsondid not show a clear performance regression